<html>
<head><meta charset="utf-8"><title>Old `quote` patch · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Old.20.60quote.60.20patch.html">Old `quote` patch</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="177757784"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Old%20%60quote%60%20patch/near/177757784" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Old.20.60quote.60.20patch.html#177757784">(Oct 09 2019 at 21:26)</a>:</h4>
<p><span class="user-mention" data-user-id="116015">@Alex Crichton</span> Ages ago you gave me this patch for <code>quote</code>, and it gave some speedups: <a href="https://paste.mozilla.org/nyLL8KiZ" target="_blank" title="https://paste.mozilla.org/nyLL8KiZ">https://paste.mozilla.org/nyLL8KiZ</a></p>



<a name="177757817"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Old%20%60quote%60%20patch/near/177757817" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Old.20.60quote.60.20patch.html#177757817">(Oct 09 2019 at 21:27)</a>:</h4>
<p>There was some issue with it using a Rust feature that was newish, so dtolnay didn't want to include it until later</p>



<a name="177757831"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Old%20%60quote%60%20patch/near/177757831" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Old.20.60quote.60.20patch.html#177757831">(Oct 09 2019 at 21:27)</a>:</h4>
<p>I just tried updating my repo with that patch applied and got conflicts. Anyway, I'm wondering if it's still relevant?</p>



<a name="177757977"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Old%20%60quote%60%20patch/near/177757977" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Old.20.60quote.60.20patch.html#177757977">(Oct 09 2019 at 21:29)</a>:</h4>
<p><a href="https://github.com/alexcrichton/proc-macro2/pull/94#issuecomment-392649679" target="_blank" title="https://github.com/alexcrichton/proc-macro2/pull/94#issuecomment-392649679">https://github.com/alexcrichton/proc-macro2/pull/94#issuecomment-392649679</a> is relevant</p>



<a name="177758034"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Old%20%60quote%60%20patch/near/177758034" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Old.20.60quote.60.20patch.html#177758034">(Oct 09 2019 at 21:30)</a>:</h4>
<p>Oh, <a href="https://github.com/dtolnay/quote/pull/91" target="_blank" title="https://github.com/dtolnay/quote/pull/91">https://github.com/dtolnay/quote/pull/91</a> was filed and then closed</p>



<a name="177758057"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Old%20%60quote%60%20patch/near/177758057" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Old.20.60quote.60.20patch.html#177758057">(Oct 09 2019 at 21:30)</a>:</h4>
<p>/me will try that code out</p>



<a name="177760180"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Old%20%60quote%60%20patch/near/177760180" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Old.20.60quote.60.20patch.html#177760180">(Oct 09 2019 at 22:03)</a>:</h4>
<p><span class="user-mention" data-user-id="120989">@nnethercote</span> oh lord the macros are way more complicated than I remember now</p>



<a name="177760187"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Old%20%60quote%60%20patch/near/177760187" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Old.20.60quote.60.20patch.html#177760187">(Oct 09 2019 at 22:03)</a>:</h4>
<p>I dunno if that optimization is in there nowadays</p>



<a name="177760191"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/Old%20%60quote%60%20patch/near/177760191" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/Old.20.60quote.60.20patch.html#177760191">(Oct 09 2019 at 22:03)</a>:</h4>
<p>I'd ping @dtolnay to learn for sure</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>